Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification badge counter persistant or wrong number displayed #1964

Closed
sekurilabs opened this issue Mar 7, 2023 · 34 comments · Fixed by #1988
Closed

Notification badge counter persistant or wrong number displayed #1964

sekurilabs opened this issue Mar 7, 2023 · 34 comments · Fixed by #1988

Comments

@sekurilabs
Copy link

After the latest update I have noticed the notification badge count is +1 than the actual number of new notifications. For example I get an email, Geary icon badge shows 2 new emails.
For Teams for Linux for example the number of notification doesn't go away after the message is read, it's persistent and only way to clear the count is to restart the shell. Application restart doesn't reset the counter.

@3v1n0
Copy link
Collaborator

3v1n0 commented Mar 8, 2023

Notification badges now also includes the tray notifications you have. This could be probably be re-considered in case an application provides its own counting though.

@vageliskatsiotis
Copy link

Noticed this today after the last update of D2D in Thunderbird. When I deactivated the extension and the initial dock did not have the notification number. Reactivated and it was there again. Also does not go away even if I read all of the emails. I have to restart gnome shell for it to go away

@fabd
Copy link

fabd commented Mar 8, 2023

Fyi, after the extension upgrade to v79 I am seeing a badge on the Files app. Never saw this before:

Screenshot from 2023-03-08 15-28-13

@jrom99
Copy link
Contributor

jrom99 commented Mar 8, 2023

I have the same problem on Firefox after a recent update (dash-to-dock 79, gnome-shell 43.3, fedora 37).

@3v1n0
Copy link
Collaborator

3v1n0 commented Mar 8, 2023

Can you verify whether you've notifications involving these apps in the notifications tray?

The reason why the emblems are added is the fix for #20, they can be disabled from d2d settings or using the do-not-disturb mode.

@jrom99
Copy link
Contributor

jrom99 commented Mar 8, 2023

Yes, I had some Outlook notifications in the calendar top popup, but they had already been addressed within Firefox.

@3v1n0
Copy link
Collaborator

3v1n0 commented Mar 8, 2023

Eh, that's not something we can check, the feature here is to show the number of unread notifications in the tray.

In case you don't want this feature, there's an option to disable it.

@vladamarek
Copy link

I have the same problem and on some launchers I can't get rid of those notifications:

image

The issue appeared after upgrading gnome-shell-extension-dash-to-dock from 78-1 to 79-1.

@jrom99
Copy link
Contributor

jrom99 commented Mar 9, 2023

In that case, the badge's presence doesn't seem to be consistent, since I can close the terminal to erase its badge, but closing Firefox won't do anything. I'll take a look if a report has been issued about the badge's number's size, since it's too small to be visible.

image

Wouldn't it be better if the badge disappeared if the window came into focus or the program closed instead of being dependent on the top calendar popup?

@jrom99

This comment was marked as duplicate.

@mzryz
Copy link

mzryz commented Mar 9, 2023

Just want to add that my notifications aren't going away/clearing either since the last upgrade - I had to disable emblems in the settings. I also have to 'scroll up' inside the dash-to-dock settings to see all the options (it automatically scrolls down as soon as I open settings! Took me ages to figure this out, probably because I use 120% font size in Gnome)

@3v1n0
Copy link
Collaborator

3v1n0 commented Mar 10, 2023

@mzryz interesting to hear.

As per settings, it's a bit bad looking because we're still supporting Gtk3 used in some old GNOME versions, so we are a bit limited in how to handle the window.

@3v1n0
Copy link
Collaborator

3v1n0 commented Mar 10, 2023

What do you get running this in alt+f2 -> lg (looking glass): Main.messageTray.getSources().map(s => s.notifications.map(n => n.resident))

And also: Main.messageTray.getSources().map(s => s.notifications.map(n => n.source.app.id || n.source._app.id))

@jrom99
Copy link
Contributor

jrom99 commented Mar 10, 2023

>>>Main.messageTray.getSources().map(s => s.notifications.map(n => n.resident))
r(0) = false,false
>>>Main.messageTray.getSources().map(s => s.notifications.map(n => n.source.app || n.source._app.id))
r(1) = [object instance wrapper GIName:Shell.App jsobj@0xhex-number native@0xhex-number], [object instance wr...

I can't copy the text in that window, and the buttons don't have tooltips, so I'm not sure if I did everything right.

@3v1n0
Copy link
Collaborator

3v1n0 commented Mar 10, 2023

You can get the full text by doing print(Main.messageTray.getSources().map(s => s.notifications.map(n => n.source.app.id || n.source._app.id))) and then checking your journalctl /usr/bin/gnome-shell

@jrom99
Copy link
Contributor

jrom99 commented Mar 10, 2023

mar 09 22:19:18 n gnome-shell[1597]: meta_window_set_stack_position_no_sync: assertion 'window->stack_position >= 0' failed

This was the last line (and only in the 22h19 mark).

@pled
Copy link

pled commented Mar 11, 2023

So if my understanding is correct, we now have badge counters including tray notifications or we have to disable "show icons emblems" in parameters, and then we don't have the previous behaviour (which was the best to my opinion) ?

@paroj
Copy link

paroj commented Mar 11, 2023

Notification badges now also includes the tray notifications you have. This could be probably be re-considered in case an application provides its own counting though.

this is a drastic departure from the previous UnityAPI based behaviour:
https://wiki.ubuntu.com/Unity/LauncherAPI#Count

previously it would display an application-defined "count", while now it adds a different quantity (notifications) without considering the applications intention.

This would probably be fine, if you just introduced the count badges, but as they were available previously this is a bug on 2 levels

  1. it breaks UX as described above. There are existing user expectations that no longer hold
  2. it breaks the UnityAPI by adding random numbers on what the application wants to convey

@mickeyr
Copy link

mickeyr commented Mar 27, 2023

Anyone know of a good replacement for dash-to-dock that doesn't mess up the notification count?

@3v1n0
Copy link
Collaborator

3v1n0 commented Mar 28, 2023

@mickeyr there's an option, just disable that.

@3v1n0
Copy link
Collaborator

3v1n0 commented Mar 28, 2023

@paroj fair, I think we can do two things:

  • Show another counter just for notifications
  • Don't bother showing notifications count in apps that provide such data.

In any case this is something we can easily customize in settings, I personally prefer to have a sum of them but it could be not the case for other people.

@pled
Copy link

pled commented Mar 28, 2023

@3v1n0 : "there's an option, just disable that."

The option disable ALL notifications (e.g. new emails) so this is not was we expect (previous behaviour).

@mickeyr

You may try dock-from-dash, a simple dock that does use native GNOME Shell dash.

@paroj
Copy link

paroj commented Mar 28, 2023

I think we can do two things:

@3v1n0 actually, I would suggest a combination of both.

For applications that do provide LauncherAPI data, display it as before. Do not display notification counts here as chances are that the application is already doing it in a more sophisticated way.

For applications that do not provide LauncherAPI data, display the notification count, but use a different color. This makes clear that this is a different kind of data. This is an important cue for the users to know what the numbers mean that they are looking at.

@christophlsa
Copy link

@mickeyr there's an option, just disable that.

But does this disable all the notification icons, as others have said?

I've been really annoyed by this behaviour for weeks now. At least now I know it comes from the notifications and not the applications. I have already checked the settings but have only found the option to disable this notification icon completely.

In my opinion, this is not really good UX. When you see the icon with a number on it, you usually click on the application to see if there is anything new, not on the notifications at the top.

@paroj
Copy link

paroj commented Apr 2, 2023

I've been really annoyed by this behaviour for weeks now

to meanwhile get back to a sane behavior you can download the previous release:
https://github.com/micheleg/dash-to-dock/releases/tag/extensions.gnome.org-v78

then change the version to 79 here, so you dont get auto-updated:

"version": 78

the run make install to overwrite the current one.

@wtechgo
Copy link

wtechgo commented Apr 11, 2023

I had the same issue but after reading here I tried clearing the notifications (click the date in top bar) and the red circles in dash2dock went away.

I toggled the "do not disturb" and now the issue is permanently gone :)

@3v1n0
Copy link
Collaborator

3v1n0 commented Apr 12, 2023

Ok, more options and behaviors are now handled in #1988 pull request, please give it a try, you should get these options:

image

@binarykitchen
Copy link

OMG this issue has haunted me for many weeks, I even contacted Slack's technical support and they pointed me to this thread.

@mickeyr
Copy link

mickeyr commented May 29, 2023

Yeah, the new option still doesn’t fix it for me on fedora

@binarykitchen
Copy link

I do not have this extension installed at all, yet I'm experiencing the same problem. My guess, it's a different extension causing this.

Maybe everyone who's experiencing this problem should share a list of installed extensions and their versions here. This might give us a clue what causes notifications never to go away.

Here's my list: https://gist.github.com/binarykitchen/2f41ac2cff36c82160f5503eac6658f5

@mickeyr
Copy link

mickeyr commented May 29, 2023

Recheck the last one in your list, it is in fact this extension

@binarykitchen
Copy link

"Ubuntu Dock"? But this repository is called "Dash to Dock". That's not the same name? This got me misleaded.

@mickeyr
Copy link

mickeyr commented May 30, 2023

look at the URL, it's the same project, just a different branch

https://github.com/micheleg/dash-to-dock/tree/ubuntu-dock

ubuntu-dock@ubuntu.com
  Name: Ubuntu Dock
  Description: A dock for the Gnome Shell, default Ubuntu experience. This extension is a modified version of Dash To Dock with different defaults. Dash To Dock can be installed to replace it and give more (but unsupported) configuration options.
  Path: /usr/share/gnome-shell/extensions/ubuntu-dock@ubuntu.com
  ---> URL: https://micheleg.github.io/dash-to-dock/
  Original author: micxgx@gmail.com
  Version: 79
  State: ENABLED

@RossContino1
Copy link

You actually have to clear the notification panel manually and then the badges match. Press the super key (Windows button) + V and clear list. All your badges will sync and be correct. Gnome stores all your notifications until you clear them and all are reflected in the application badges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.